[PATCH] Add a winbind localauth plugin for MIT Kerberos

[Alexander Bokovoy]

On to, 21 kesä 2018, Andreas Schneider wrote:
> On Thursday, 21 June 2018 11:09:22 CEST Alexander Bokovoy wrote:
> > On to, 21 kesä 2018, Andreas Schneider wrote:
> > > +krb5_error_code
> > > +localauth_winbind_initvt(krb5_context context,
> > > +			 int maj_ver,
> > > +			 int min_ver,
> > > +			 krb5_plugin_vtable vtable)
> > > +{
> > > +	krb5_localauth_vtable vt = (krb5_localauth_vtable)vtable;
> > > +
> > > +	if (maj_ver != 1 || min_ver != 1) {
> > > +		return KRB5_PLUGIN_VER_NOTSUPP;
> > > +	}
> > 
> > The only issue I have is with this if() statement.
> > Since the plugin major/minor version is not really exposed anywhere in
> > MIT Kerberos, only hardcoded in load_localauth_modules() as (1,1), may
> > be it is better to do explicit test here or drop the test completely?
> 
> I've removed the check for min_ver. The maj_ver change is normally the issue 
> as it means the API broke. I've added a log message for that.
RB+. Please push.


-- 
/ Alexander Bokovoy