[PATCH] Add a winbind localauth plugin for MIT Kerberos

Alexander Bokovoy ab at samba.org
Thu Jun 21 09:09:22 UTC 2018


On to, 21 kesä 2018, Andreas Schneider wrote:
> +krb5_error_code
> +localauth_winbind_initvt(krb5_context context,
> +			 int maj_ver,
> +			 int min_ver,
> +			 krb5_plugin_vtable vtable)
> +{
> +	krb5_localauth_vtable vt = (krb5_localauth_vtable)vtable;
> +
> +	if (maj_ver != 1 || min_ver != 1) {
> +		return KRB5_PLUGIN_VER_NOTSUPP;
> +	}
The only issue I have is with this if() statement.
Since the plugin major/minor version is not really exposed anywhere in
MIT Kerberos, only hardcoded in load_localauth_modules() as (1,1), may
be it is better to do explicit test here or drop the test completely?

-- 
/ Alexander Bokovoy



More information about the samba-technical mailing list