[PATCH] ldb: check return values
Volker.Lendecke at SerNet.DE
Thu Jun 21 07:53:36 UTC 2018
On Wed, Jun 20, 2018 at 03:37:29PM -0700, Jeremy Allison via samba-technical wrote:
> On Tue, Jun 19, 2018 at 08:59:25AM +0000, Andrej Gessel via samba-technical wrote:
> > Hello Andrew,
> > BUG: https://bugzilla.samba.org/show_bug.cgi?id=13477
> > I have found another "bad" place. Attached both patches.
> > Gitlab CI Pipeline: https://gitlab.com/samba-team/devel/samba/pipelines/24121645
> Thanks Andrej, These both look good to me.
> RB+. Can I get a second Team reviewer please ?
Doesn't the second one contain a memleak? The patch does not make it
worse, but when touching this code I think we need to
talloc_free(keys) in this return path.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical