[RFC] Performance improvements

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Jun 20 09:22:53 UTC 2018


On Mon, Jun 18, 2018 at 10:04:03AM +0200, Swen Schillig via samba-technical wrote:
> Attached is the patchset in question.
> Even though the set consists of 10 patches I wouldn't call them all
> micro-patches..but they're as small as possible I guess.

2/10 is an obvious RB+ by me.

10/10 is really, really fishy. We should never handle more than one
event from a single tevent_loop_once. Not a formal NACK, but this
needs thorough review by people more familiar with the core of ctdb's
request handling.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de



More information about the samba-technical mailing list