[PATCH] More python3 low hanging fruit

Andrew Bartlett abartlet at samba.org
Tue Jun 19 22:17:55 UTC 2018

On Tue, 2018-06-19 at 11:19 +0100, Noel Power via samba-technical
> Hi,
> Firstly just some I think low impact python2/python3 compatibility
> patches for review(more of these on the way), please see
>  * attached patches
>   * or branch
> https://gitlab.com/samba-team/devel/samba/commits/npower-python3-misc
>   * and also pipeline
> https://gitlab.com/samba-team/devel/samba/pipelines/23886615
> please have a look at the above (and attached) for review (and hopefully
> push to master)

Reviewed-by: Andrew Bartlett <abartlet at samba.org> 

Pushed to autobuild.

> Secondly I am now hosting the latest WIP patches on gitlab (well not
> quite the latest, I have since I uploaded these I have more in progess
> in a private branch that I hope I will push today or tomorrow for CI)
> Please see
>   * branch
> https://gitlab.com/samba-team/devel/samba/commits/npower-py2-py3-wip
>   * https://gitlab.com/samba-team/devel/samba/pipelines/24054219
> Again the usual caveats apply
>   * this branch is not for review (but comments welcome)
>   * it's real WIP patches, be aware the patches there need to be
> reorganized, cleaned up etc.
> But I'd like at least to share there is a bit of progress here,
> source4/selftest/tests.py has most of the planoldpythontestsuite &
> planpythontestsuite tests converted (at least to the point they run and
> succeed with python2 AND python3)

Nice!  I'll look at this when I get a chance to see what you have been
up to.

Andrew Bartlett
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list