[RFC] Performance improvements
jra at samba.org
Tue Jun 19 18:53:04 UTC 2018
On Mon, Jun 18, 2018 at 12:57:14PM +0200, Swen Schillig via samba-technical wrote:
> On Mon, 2018-06-18 at 10:58 +0200, Andreas Schneider wrote:
> > On Monday, 18 June 2018 10:04:03 CEST Swen Schillig via samba-
> > technical wrote:
> > There are some nice cleanups.
> > In the first patch:
> > + int num_ready;
> > + int new_size = num_ready + queue->buffer.length;
> > Please use size_t.
> Won't send the updated patch series yet...
> expecting more comments / updates soon.
Don't have a lot of bandwidth right now, but can you
check all the packet + offset calculations are integer
wrap safe (yes I know they're updates of existing
code, but it's nice to add safety when stuff gets
More information about the samba-technical