[s3] CID 1433607 Out-of-bounds-write

[Jeremy Allison]

On Mon, Jun 18, 2018 at 09:12:56PM +0200, Swen Schillig wrote:
> On Mon, 2018-06-18 at 11:49 -0700, Jeremy Allison wrote:
> > On Mon, Jun 18, 2018 at 02:47:59PM +0200, Swen Schillig via samba-
> > technical wrote:
> > > On Wed, 2018-06-13 at 12:57 -0600, David Mulder via samba-technical
> > > wrote:
> > > > rb+
> > > > 
> > > > 
> > > > On 06/13/2018 03:04 AM, Swen Schillig via samba-technical wrote:
> > > > > Please review and push if happy.
> > > > > 
> > > 
> > > Any else considering this one ?
> > 
> > I'm planning to review this. This is *tricky* code.
> 
> Very good, thanks.
> 
> Maybe you can explain as well why this is **tricky**.

Look at how it moves around in the packet. That's the
tricky part.

> This is clearly an out-of-bounds write which is wrong.

Not arguing with that.

> ...it probably has no bad side-effects as it is "over-written" later
> anyway, but that is not making it better in the first place.

"probably" :-). That's why I need to understand what
is going on here before applying the patch.