[smb3] unreachable code and memory leaks
Steve French
smfrench at gmail.com
Mon Jun 18 17:18:25 UTC 2018
Gustavo,
Thx for pointing this out. Let me know if this patch addresses what
you found. Code is experimental mount option but extremely important
to get right due to move away from SMB1/CIFS which had posix
extensions.
On Mon, Jun 18, 2018 at 11:55 AM, Steve French <smfrench at gmail.com> wrote:
> On Mon, Jun 18, 2018 at 8:07 AM, Gustavo A. R. Silva
> <gustavo at embeddedor.com> wrote:
>> Hi Steve,
>>
>> While doing some static analysis I came across the following piece of code at fs/cifs/smb2pdu.c:2017:
>>
>> 2017 if (n_iov > 2) {
>> 2018 struct create_context *ccontext =
>> 2019 (struct create_context *)iov[n_iov-1].iov_base;
>> 2020 ccontext->Next =
>> 2021 cpu_to_le32(iov[n_iov-1].iov_len);
>> 2022 }
>
> Good catch - this is harmless (and experimental mount option) - cut
> and paste - unneeded clause.
> Fixing now
>
>
>> Also, it seems there are multiple places in which memory allocated for *path* is leaking:
>>
>> 1946 else
>> 1947 return -EIO;
>>
>> 1951 if (rc)
>> 1952 return rc;
>>
>> 1987 if (rc) {
>> 1988 cifs_small_buf_release(req);
>> 1989 return rc;
>> 1990 }
>
> Cleaning that up now. Will post a patch - thx.
>
>
> --
> Thanks,
>
> Steve
--
Thanks,
Steve
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-smb3-fix-memory-leak-in-smb311_posix_mkdir.patch
Type: text/x-patch
Size: 2329 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180618/92e9866b/0001-smb3-fix-memory-leak-in-smb311_posix_mkdir.bin>
More information about the samba-technical
mailing list