[PATCH] 3 small cleanups

Volker Lendecke Volker.Lendecke at SerNet.DE
Mon Jun 18 14:14:11 UTC 2018


Hi!

Review appreciated!

Thanks, Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
From 45024eede846ff72b9f054bc61aaaafd6938c1ed Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Fri, 4 May 2018 21:02:41 +0200
Subject: [PATCH 1/3] idmap_hash: Align integer types

Loop-variable and bound should be the same type

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 source3/winbindd/idmap_hash/idmap_hash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source3/winbindd/idmap_hash/idmap_hash.c b/source3/winbindd/idmap_hash/idmap_hash.c
index 589027154d4..0f4b0b8b064 100644
--- a/source3/winbindd/idmap_hash/idmap_hash.c
+++ b/source3/winbindd/idmap_hash/idmap_hash.c
@@ -110,7 +110,7 @@ static NTSTATUS idmap_hash_initialize(struct idmap_domain *dom)
 	NTSTATUS nt_status = NT_STATUS_UNSUCCESSFUL;
 	struct winbindd_tdc_domain *dom_list = NULL;
 	size_t num_domains = 0;
-	int i;
+	size_t i;
 
 	DBG_ERR("The idmap_hash module is deprecated and should not be used. "
 		"Please migrate to a different plugin. This module will be "
-- 
2.17.1


From 931ac552eed625bb8baeba491a358ead8562210a Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Wed, 25 Apr 2018 12:05:37 +0200
Subject: [PATCH 2/3] lib: Align integer types

Loop-variable and bound should be the same type

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 source3/lib/srprs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source3/lib/srprs.c b/source3/lib/srprs.c
index a3fd0c3e48a..db0448c1788 100644
--- a/source3/lib/srprs.c
+++ b/source3/lib/srprs.c
@@ -128,7 +128,7 @@ bool srprs_hex(const char** ptr, size_t len, unsigned* u)
 	const char *str = *ptr;
 	const char *pos = *ptr;
 	int ret;
-	int i;
+	size_t i;
 	char buf[8+1] = {};
 
 	assert((len >= 1) && (len <= 8));
-- 
2.17.1


From c773fef588db50421e9276843a0bb32e7d820e5a Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Thu, 3 May 2018 11:47:44 +0200
Subject: [PATCH 3/3] winbind: Fix a typo

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 source3/winbindd/winbindd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source3/winbindd/winbindd.c b/source3/winbindd/winbindd.c
index 34607ca653e..f0f0eef7bfc 100644
--- a/source3/winbindd/winbindd.c
+++ b/source3/winbindd/winbindd.c
@@ -1027,7 +1027,7 @@ static void remove_client(struct winbindd_cli_state *state)
 	 * before closing the fd.
 	 *
 	 * Otherwise we might hit a race with close_conns_after_fork() (via
-	 * winbindd_reinit_after_fork()) where a file description
+	 * winbindd_reinit_after_fork()) where a file descriptor
 	 * is still open in a child, which means it's still active in
 	 * the parents epoll queue, but the related tevent_fd is already
 	 * already gone in the parent.
-- 
2.17.1



More information about the samba-technical mailing list