[PATCH] Remove warning in testparm

Andreas Schneider asn at samba.org
Mon Jun 18 13:24:11 UTC 2018


If OK, review and push appreciated.


Thanks,


	Andreas

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org
-------------- next part --------------
>From 7198b2bc647c6a16dc92f9bda95c19001d33d155 Mon Sep 17 00:00:00 2001
From: Andreas Schneider <asn at samba.org>
Date: Mon, 18 Jun 2018 15:22:18 +0200
Subject: [PATCH] testparm: Remove warning from the last century

Signed-off-by: Andreas Schneider <asn at samba.org>
---
 source3/utils/testparm.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/source3/utils/testparm.c b/source3/utils/testparm.c
index a53eea5b8cc..8113eea0020 100644
--- a/source3/utils/testparm.c
+++ b/source3/utils/testparm.c
@@ -712,16 +712,6 @@ static void do_per_share_checks(int s)
 		ret = do_global_checks();
 	}
 
-	for (s=0;s<1000;s++) {
-		if (VALID_SNUM(s))
-			if (strlen(lp_servicename(talloc_tos(), s)) > 12) {
-				fprintf(stderr, "WARNING: You have some share names that are longer than 12 characters.\n" );
-				fprintf(stderr, "These may not be accessible to some older clients.\n" );
-				fprintf(stderr, "(Eg. Windows9x, WindowsMe, and smbclient prior to Samba 3.0.)\n" );
-				break;
-			}
-	}
-
 	for (s=0;s<1000;s++) {
 		if (VALID_SNUM(s) && (skip_logic_checks == 0)) {
 			do_per_share_checks(s);
-- 
2.17.1



More information about the samba-technical mailing list