impersonation patchset part2 (Re: FLAG_CASELESS_PATHNAMES/SMBFLG_CASELESS in set_current_service())

Stefan Metzmacher metze at
Sun Jun 17 20:42:04 UTC 2018

Am 15.06.2018 um 01:08 schrieb Jeremy Allison via samba-technical:
> On Thu, Jun 14, 2018 at 08:01:13PM +0200, Stefan Metzmacher wrote:
>>>>>> Windows servers ignore FLAG_CASELESS_PATHNAMES completely,
>>>>>> but we do some magic just for smbclient and cifs.ko.
>>>>>> Only [lib]smbclient supports changing the flag on a per request basis,
>>>>>> but is it really used in practice?
>>>>> No.
>>>> So we can really remove smbc_setOptionCaseSensitive() ?
>>>> And the "case_sensitive" smbclient command?
>>> Yes, I think we can.
>> And don't worry about the ABI change?
> What are our options here ? smbc_setOptionCaseSensitive()
> will become a no-op, so we either leave it and document
> it's not useful, or remove it and uprev the library major
> number I think.

I think I'll just defer this, we can think about it again when we want
to finish the unix extension stuff.

>>>>> POSIX opens (SMB1 global switch or SMB3 POSIX create context)
>>>>> always mean case sensitive.
>>>> Good.
>>>>>> Where we also have req->posix_pathnames and UCF_POSIX_PATHNAMES?
>>>>> Yeah, I think so - see above.
>>>>>> Any ideas how to move forward here?
>>>>> Does my plan work ? The only issues I can see are when we're
>>>>> running on a Linux system that actually *has* a case-insensitive
>>>>> filesystem underneath (XFS or ZFS mounted in case-insensitive mode).
>>>> Then the filesystem should not announce FILE_CASE_SENSITIVE_SEARCH.
>>> Yes, that makes sense. The client can then know that
>>> even if it asks for POSIX extensions it will not get
>>> case-sensitive pathnames.
>> Should we keep the "case sensitive" option to control this?
>> Or should we better remove it completely.
> I think we keep it. That way, even on a case-sensitive filesystem
> we can set "case sensitive = yes/default case = upper" to
> preserve the large directory optimization.

I don't understand that, I guess I would have to dig deeper into the
related code, which I'm trying to avoid currently.

>> And autodetect FILE_CASE_SENSITIVE_SEARCH from the local filesystem
>> or add a new separate option for it?
> What option name are you thinking of here ?

I'm not sure if we need one at all...


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <>

More information about the samba-technical mailing list