[PATCHES] heimdal: lib/krb5: do not fail set_config_files due to parse error

Alexander Bokovoy ab at samba.org
Sat Jun 16 08:37:32 UTC 2018


On la, 16 kesä 2018, Björn Baumbach via samba-technical wrote:
> Hi!
> 
> There is an (already well known) bug in our heimdal library, which
> drives users crazy:
> https://bugzilla.samba.org/show_bug.cgi?id=11573
> 
> I've ported the needed patches to solve this issue.
> 
> The first patch is sufficient, to fix the bug.
> 
> The second patch is needed to apply the original patch (the third one)
> from Nicolas Williams.
> 
> The third patch is the one to process the include directives of the
> krb5.conf file, which was mentioned in the bug report:
> https://bugzilla.samba.org/show_bug.cgi?id=11573#c5
> 
> Additionally I've detected, that the RHEL krb5-libs package patches the
> /etc/krb5.conf in the post installation section:
> 
> if ! grep -q 'includedir /etc/krb5.conf.d' /etc/krb5.conf ; then
>     sed -i '1i # Other applications require this directory to perform
> krb5 configuration.\nincludedir /etc/krb5.conf.d/\n' /etc/krb5.conf
> fi
> 
> So it might be helpful to just commend out the includedir line, instead
> of removing.
I'd rather have includedir support than to comment out or removing the
directive. I think these patches are OK, so LGTM and please push.

-- 
/ Alexander Bokovoy



More information about the samba-technical mailing list