[PATCH: DNS Scavenging]

[Stefan Metzmacher]

Hi Aaron,

> Implementation of DNS scavenging as per [MS-DNSP]

Thanks! The patches look very promising!

Can you please format multi line comments like:

/*
 * multi
 * line
 */

and avoid '//' comments, see README.Coding for more details.

I was working on the same topic before, but never had the time to
finish my work.

I rebased my state on master and pushed it to:
https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-dns

Can you read through this and check if you're patches cover the same?

Please check my DNS_COMMON_TIMESTAMP_STATIC,
DNS_COMMON_TIMESTAMP_UPDATED and DNS_COMMON_TIMESTAMP_NEW approach
in order to do the timestamp updates as Windows.
There's an important difference between UPDATED and NEW.
An dynamic update to an entry that has static records, uses
static also for new records.

See
https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=98627219e8ed
and
https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=1d81e96351cc

I think the most challenging part is to make sure we still can
detect the broken records we added so far and let dbcheck fix them.
And we should also fix them during the fetch from the db, so that
we treat them as they would have been created correctly.
Maybe this can be done using the hardcoded dwSerial = 110 we used so far
and implement the correct serial behavior of Windows.

Also have a look at the various bug urls in the commit messages
and also add them to your code where you fix these bugs.

Thanks!
metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180615/ac36fdbf/signature.sig>