[Patches] Preparation for tevent impersonation (part1)

Jeremy Allison jra at samba.org
Thu Jun 14 18:11:08 UTC 2018


On Thu, Jun 14, 2018 at 08:07:04PM +0200, Stefan Metzmacher wrote:
> Hi Jeremy,
> 
> >>> You should free the acl in the failure cases (like before) since you return
> >>> NULL to the caller.
> >>
> >> Good point. Here's an updated patch. This maybe should be
> >> better merged into the original changed patch #6.
> >>
> >> I'll let metze decide.
> > 
> > Here is an updated complete patchset with the
> > descriptions for patches 22/41 and 23/41 fixed,
> > added signed-off-by in patch 37/41 and the make_simple_acl()
> > fixes merged into patch 6/41.
> > 
> > I'm good with this version if you're happy.
> 
> Thanks! I'll have a look tomorrow.

Thanks !

> Maybe the talloc_stackframe() bug, was also causing the problem
> with my part2 (which is on top of part1).

Maybe, depends no where it was crashing. I've logged
bug:

https://bugzilla.samba.org/show_bug.cgi?id=13474

in order to get it fixed in release versions.



More information about the samba-technical mailing list