[Patches] Preparation for tevent impersonation (part1)
jra at samba.org
Thu Jun 14 17:32:01 UTC 2018
On Thu, Jun 14, 2018 at 07:28:29PM +0200, David Disseldorp via samba-technical wrote:
> On Thu, 14 Jun 2018 10:19:15 -0700, Jeremy Allison via samba-technical wrote:
> > TALLOC_FREE(frame);
> > change in make_simple_acl(). Having said that
> > the stackframe handling in make_simple_acl()
> > was utterly broken before that anyway (it
> > created a new stackframe that was left
> > hanging around on exit from the function).
> Talloc stackframe handling is broken in many of places, unfortunately.
> Continuing to use it for event based async code will only lead to more
> problems in future IMO.
I disagree - it's working in all essential codepaths (that's
why we don't crash more often than we already do :-).
This was a broken test-case path. I'm planning to log a bug
and fix this in release versions too.
If you know of any other Talloc stackframe handling breakage
please report ASAP !
More information about the samba-technical