[Patches] Preparation for tevent impersonation (part1)

[Jeremy Allison]

On Thu, Jun 14, 2018 at 01:16:44PM -0400, jim via samba-technical wrote:
> On 6/14/2018 1:12 PM, Jeremy Allison via samba-technical wrote:
> > On Thu, Jun 14, 2018 at 10:03:42AM -0700, Jeremy Allison via samba-technical wrote:
> > > On Thu, Jun 14, 2018 at 06:48:39PM +0200, Stefan Metzmacher wrote:
> > > > Hi Jeremy,
> > > > 
> > > > > OK, finishing up the review with this patch inserted
> > > > > before #6 in the previous set. Should get this finished
> > > > > (and pushed) tomorrow.
> > > > Here's an updated patchset.
> > > > 
> > > > The author of the first two commits is fixed and the commit message
> > > > of the last one is extended (as requested by Andreas).
> > > FYI: Descriptions for patches 22/41 and 23/41 are incorrect,
> > > missing signed-off-by in patch 37/41.
> > > 
> > > Other than that RB+ - looks good to me.
> > > 
> > > However I'm getting an interesting autobuild failure
> > > when I push:
> > > 
> > > I'm looking into it !
> > Found it !
> > 
> > source3/smbd/pysmbd.c:static SMB_ACL_T make_simple_acl(gid_t gid, mode_t chmod_mode)
> > 
> > return an ACL created on a talloc stackframe
> > that is freed. The additional patch is needed
> > I think. Can you add on top and review ?
> > 
> > Thanks,
> > 
> > 	Jeremy.
> You should free the acl in the failure cases (like before) since you return
> NULL to the caller.

Good point. Here's an updated patch. This maybe should be
better merged into the original changed patch #6.

I'll let metze decide.

Jeremy.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-pysmbd-Don-t-return-an-ACL-on-a-freed-talloc_stackfr.patch
Type: text/x-diff
Size: 3678 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180614/3c593649/0001-pysmbd-Don-t-return-an-ACL-on-a-freed-talloc_stackfr.diff>