[Patches] Preparation for tevent impersonation (part1)
jra at samba.org
Thu Jun 14 17:12:45 UTC 2018
On Thu, Jun 14, 2018 at 10:03:42AM -0700, Jeremy Allison via samba-technical wrote:
> On Thu, Jun 14, 2018 at 06:48:39PM +0200, Stefan Metzmacher wrote:
> > Hi Jeremy,
> > > OK, finishing up the review with this patch inserted
> > > before #6 in the previous set. Should get this finished
> > > (and pushed) tomorrow.
> > Here's an updated patchset.
> > The author of the first two commits is fixed and the commit message
> > of the last one is extended (as requested by Andreas).
> FYI: Descriptions for patches 22/41 and 23/41 are incorrect,
> missing signed-off-by in patch 37/41.
> Other than that RB+ - looks good to me.
> However I'm getting an interesting autobuild failure
> when I push:
> I'm looking into it !
Found it !
source3/smbd/pysmbd.c:static SMB_ACL_T make_simple_acl(gid_t gid, mode_t chmod_mode)
return an ACL created on a talloc stackframe
that is freed. The additional patch is needed
I think. Can you add on top and review ?
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 3307 bytes
Desc: not available
More information about the samba-technical