[Patches] Preparation for tevent impersonation (part1)

[Jeremy Allison]

On Thu, Jun 14, 2018 at 06:48:39PM +0200, Stefan Metzmacher wrote:
> Hi Jeremy,
> 
> > OK, finishing up the review with this patch inserted
> > before #6 in the previous set. Should get this finished
> > (and pushed) tomorrow.
> 
> Here's an updated patchset.
> 
> The author of the first two commits is fixed and the commit message
> of the last one is extended (as requested by Andreas).

FYI: Descriptions for patches 22/41 and 23/41 are incorrect,
missing signed-off-by in patch 37/41.

Other than that RB+ - looks good to me.

However I'm getting an interesting autobuild failure
when I push:

I'm looking into it !

Jeremy.

----------------------------------------------------------------------------------------
#3  0x00002b1b72f3d2e7 in smb_panic (why=0x2b1b72f92c75 "internal error") at ../lib/util/fault.c:170
No locals.
#4  0x00002b1b72f3cf97 in fault_report (sig=11) at ../lib/util/fault.c:84
        counter = 1
        __FUNCTION__ = "fault_report"
#5  0x00002b1b72f3cfac in sig_fault (sig=11) at ../lib/util/fault.c:95
No locals.
#6  <signal handler called>
No locals.
#7  0x00002b1b79af10fb in ndr_push_smb_acl_entry (ndr=0x5646650, ndr_flags=256, r=0x0) at default/librpc/gen_ndr/ndr_smb_acl.c:270
        _status = 90465872
#8  0x00002b1b79af15fd in ndr_push_smb_acl_t (ndr=0x5646650, ndr_flags=768, r=0x4cd5bc0) at default/librpc/gen_ndr/ndr_smb_acl.c:321
        _status = 32767
        cntr_acl_0 = 0
#9  0x00002b1b7383cc54 in ndr_push_struct_blob (blob=0x7fffc88b9910, mem_ctx=0x4636560, p=0x4cd5bc0, fn=0x2b1b79af14b4 <ndr_push_smb_acl_t>) at ../librpc/ndr/ndr.c:1337
        _status = 11035
        ndr = 0x5646650
#10 0x00002b1b7f1c13c3 in fake_acls_acl2blob (mem_ctx=0x4636560, acl=0x4cd5bc0) at ../source3/modules/vfs_fake_acls.c:239
        ndr_err = 11035
        blob = {data = 0x2f5a070 "/memdisk/jra/a/b2686137/samba-ad-dc/bin/ab/ad_dc/statedir/sysvol/tmpptJ_n1", length = 47397096663344}
        __FUNCTION__ = "fake_acls_acl2blob"
#11 0x00002b1b7f1c17c4 in fake_acls_sys_acl_set_file (handle=0x2d2ddf0, smb_fname=0x4b01bd0, acltype=0, theacl=0x4cd5bc0) at ../source3/modules/vfs_fake_acls.c:333
        ret = 0
        name = 0x0
        frame = 0x4636560
        blob = {data = 0x7fffc88b99a0 "\320\033\260\004", length = 47396861674076}
        __FUNCTION__ = "fake_acls_sys_acl_set_file"
#12 0x00002b1b79a0bd5b in smb_vfs_call_sys_acl_set_file (handle=0x2d2ddf0, smb_fname=0x4b01bd0, acltype=0, theacl=0x4cd5bc0) at ../source3/smbd/vfs.c:2537
No locals.
#13 0x00002b1b7f1c7b05 in sys_acl_set_file_xattr (handle=0x2d0c080, smb_fname=0x4b01bd0, type=0, theacl=0x4cd5bc0) at ../source3/modules/vfs_acl_xattr.c:173
        ret = 0
#14 0x00002b1b79a0bd5b in smb_vfs_call_sys_acl_set_file (handle=0x2d0c080, smb_fname=0x4b01bd0, acltype=0, theacl=0x4cd5bc0) at ../source3/smbd/vfs.c:2537
No locals.
#15 0x00002b1b767f41cf in set_sys_acl_conn (fname=0x2b1b7bf250c4 "/memdisk/jra/a/b2686137/samba-ad-dc/bin/ab/ad_dc/statedir/sysvol/tmpptJ_n1", acltype=0, theacl=0x4cd5bc0, conn=0x41fe1d0) at ../source3/smbd/pysmbd.c:95
        ret = 0
        smb_fname = 0x4b01bd0
        saved_umask = 0
        frame = 0x45aa040
#16 0x00002b1b767f4f25 in py_smbd_set_simple_acl (self=0x0, args=0x2b1b7be78780, kwargs=0x0) at ../source3/smbd/pysmbd.c:394
        kwnames = {0x2b1b767f621e "fname", 0x2b1b767f6224 "mode", 0x2b1b767f6229 "gid", 0x2b1b767f622d "service", 0x0}
        fname = 0x2b1b7bf250c4 "/memdisk/jra/a/b2686137/samba-ad-dc/bin/ab/ad_dc/statedir/sysvol/tmpptJ_n1"
        service = 0x0
        ret = 11035
        mode = 493
        gid = 65531
        acl = 0x4cd5bc0
        frame = 0x26f0640
        conn = 0x41fe1d0
#17 0x00000000004c7f54 in PyEval_EvalFrameEx ()
No symbol table info available.
#18 0x00000000004c8762 in PyEval_EvalFrameEx ()
No symbol table info available.
#19 0x00000000004cfedc in PyEval_EvalCodeEx ()
No symbol table info available.
#20 0x00000000004c8314 in PyEval_EvalFrameEx ()
No symbol table info available.
#21 0x00000000004cfedc in PyEval_EvalCodeEx ()
No symbol table info available.
#22 0x00000000004c8314 in PyEval_EvalFrameEx ()
No symbol table info available.
#23 0x00000000004704ea in ?? ()
No symbol table info available.
#24 0x00000000004c9aa5 in PyEval_EvalFrameEx ()
No symbol table info available.
#25 0x00000000004704ea in ?? ()
No symbol table info available.
#26 0x00000000004c9aa5 in PyEval_EvalFrameEx ()
No symbol table info available.
#27 0x00000000004704ea in ?? ()
No symbol table info available.
#28 0x00000000004c9aa5 in PyEval_EvalFrameEx ()
No symbol table info available.
#29 0x00000000004704ea in ?? ()
No symbol table info available.
#30 0x00000000004c9aa5 in PyEval_EvalFrameEx ()
No symbol table info available.
#31 0x00000000004cfedc in PyEval_EvalCodeEx ()
No symbol table info available.
#32 0x0000000000596e82 in PyEval_EvalCode ()
No symbol table info available.
#33 0x0000000000596ebb in ?? ()
No symbol table info available.
#34 0x0000000000436d65 in PyRun_FileExFlags ()
No symbol table info available.
#35 0x0000000000437070 in PyRun_SimpleFileExFlags ()
No symbol table info available.
#36 0x0000000000425a23 in Py_Main ()
No symbol table info available.
#37 0x00002b1b71613f45 in __libc_start_main (main=0x425ae1 <main>, argc=18, argv=0x7fffc88baf18, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7fffc88baf08) at libc-start.c:287
        result = <optimized out>
        unwind_buf = {cancel_jmp_buf = {{jmp_buf = {0, 625918530113403043, 5721941, 140736557985552, 0, 0, -625960210103633757, 6816575530369054883}, mask_was_saved = 0}}, priv = {pad = {0x0, 0x0, 0x5b9c10 <__libc_csu_init>, 0x7fffc88baf18}, data = {prev = 0x0, cleanup = 0x0, canceltype = 6003728}}}
        not_first_call = <optimized out>
#38 0x0000000000574f7e in _start ()
No symbol table info available.