[Patches] Preparation for tevent impersonation (part1)
Jeremy Allison
jra at samba.org
Wed Jun 13 22:58:23 UTC 2018
On Wed, Jun 13, 2018 at 08:54:33PM +0200, Stefan Metzmacher wrote:
> Hi Jeremy,
>
> > In patch [PATCH 06/40] pysmbd: remove explicit talloc_stackframe() from get_conn() and name it get_conn_tos()
> >
> > py_smbd_set_simple_acl()
> > py_smbd_chown()
> >
> > are missing a TALLOC_FREE(frame) in their error paths.
> >
> > - conn = get_conn(frame, service);
> > + conn = get_conn_tos(service);
> > if (!conn) {
> >>>>>> NEEDS TALLOC_FREE(frame);
> > return NULL;
> > }
> >
> > This is an existing bug, but probably should be fixed
> > either in patch 06/40 or in an additional patch after
> > it.
>
> I have the attached patch before 06.
> Thanks!
OK, finishing up the review with this patch inserted
before #6 in the previous set. Should get this finished
(and pushed) tomorrow.
Thanks for your patience !
Jeremy.
More information about the samba-technical
mailing list