[s3] vfs_fruit: CID 1416478, 1416477, 1416476, 1416475

Christof Schmitt cs at samba.org
Wed Jun 13 17:39:35 UTC 2018


On Wed, Jun 13, 2018 at 12:14:28PM +0200, Ralph Böhme wrote:
> On Wed, Jun 13, 2018 at 09:11:56AM +0200, Swen Schillig via samba-technical wrote:
> > On Tue, 2018-06-12 at 10:55 -0700, Christof Schmitt wrote:
> > > On Fri, May 25, 2018 at 12:51:44PM +0200, Swen Schillig via samba-
> > > technical wrote:
> > > 
> > > Please use DBG_ERR instead of D_ERR, otherwise this looks good to me.
> > 
> > Patches are updated.
> > 
> > Any second reviewer, please ?
> 
> even though, in these particular cases, this will always be already checked in
> the caller, lgtm&pushed.

Would be be an option to pass fio as additional argument and avoid
VFS_FETCH_FSP_EXTENSION in the called functions?

Christof



More information about the samba-technical mailing list