[PATCH] samba-tool drs showrepl --summary

[Andrew Bartlett]

On Mon, 2018-06-11 at 10:02 +1200, Douglas Bagnall via samba-technical
wrote:
> On 11/06/18 07:09, Andrew Bartlett wrote:
> 
> > 
> > I have a fix for this, see attached.  Essentially we need to ignore
> > deleted DSAs.  These only show up in the full test environment. 
> > 
> > CI: https://gitlab.com/catalyst-samba/samba/pipelines/23590669
> > 
> > Please review and push if the CI indicates
> 
> CI was not happy, though on the bright side its complaint was relevant and
> not about nbt dgrams.
> 
> > > Also, if you could make it use self.runsubcmd() to call directly into
> > > the samba-tool code rather than re-exec()ig python etc that would be
> > > good.
> > 
> > I've not done this bit yet and this is no different to the other code
> > here so there may be a reason.
> 
> Yep, that other code led me to assume that DrsBaseTestCase lacked
> runsubcmd(), but I see that's not so.
> 
> I can look at this again tonight.

I've been looking at this again, and the next failure is:

[806(4953)/855 at 1h40m50s]
samba4.drs.samba_tool_drs_showrepl.python(vampire_dc)(vampire_dc:local)
UNEXPECTED(error):
samba4.drs.samba_tool_drs_showrepl.python(vampire_dc).samba_tool_drs_sh
owrepl.SambaToolDrsShowReplTests.test_samba_tool_showrepl_summary_all_g
ood(vampire_dc:local)
REASON: Exception: Exception: Traceback (most recent call last):
  File "/tmp/samba-
testbase/b12/samba/source4/torture/drs/python/samba_tool_drs_showrepl.p
y", line 167, in test_samba_tool_showrepl_summary_all_good
    (self.dc1, self.cmdline_creds))
  File "bin/python/samba/tests/__init__.py", line 384, in check_output
    raise BlackboxProcessError(retcode, line, stdoutdata, stderrdata)
BlackboxProcessError: Command '/tmp/samba-testbase/b12/samba/bin/samba-
tool drs showrepl --summary localdc
-USAMBADOMAIN/Administrator%locDCpass1'; exit status 1; stdout: 'There
are failing connections
Failing outbound connections:
DC=samba,DC=example,DC=com
	Default-First-Site-Name\PROMOTEDVDC via RPC
		DSA object GUID: df8cecca-8eb3-45b4-925f-2e258d7ade04
		Last attempt @ Mon Jun 11 21:57:42 2018 UTC failed,
result 8457 (WERR_DS_DRA_SINK_DISABLED)
		1 consecutive failure(s).
		Last success @ Mon Jun 11 21:57:31 2018 UTC


The issue here is that we have not force replication with everyone
before the test, and at the time of the last replication is was
disabled on the other server.

Perhaps this test is best done on a saved DB?

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba