[PATCH] samba-tool visualize uptodateness

[Andrew Bartlett]

On Mon, 2018-06-11 at 00:13 +1200, Douglas Bagnall wrote:
> On 10/06/18 16:28, Andrew Bartlett via samba-technical wrote:
> > On Sun, 2018-06-10 at 09:02 +1200, Douglas Bagnall wrote:
> > > Thanks Andrew. Pushed.
> > > 
> > > This is what I squashed in:
> > > 
> > > --- a/python/samba/netcmd/visualize.py
> > > +++ b/python/samba/netcmd/visualize.py
> > > @@ -687,11 +687,12 @@ class cmd_uptodateness(GraphCommand):
> > >      def get_utdv(self, samdb, dn):
> > >          """This finds the uptodateness vector in the database."""
> > >          cursors = []
> > > +        config_dn = samdb.get_config_basedn()
> > >          for c in dsdb._dsdb_load_udv_v2(samdb, dn):
> > >              inv_id = str(c.source_dsa_invocation_id)
> > > -            res = samdb.search(expression=("(&(invocationId=%s)"
> > > +            res = samdb.search(base=config_dn,
> > > +                               expression=("(&(invocationId=%s)"
> > >                                             "(objectClass=nTDSDSA))" % inv_id),
> > > -                               #scope=SCOPE_SUBTREE,
> > >                                 controls=["search_options:1:2"],
> > >                                 attrs=["distinguishedName", "invocationId"])
> > 
> > Thanks.  While it now won't do anything, I think you can now remove
> > the 
> > 
> > controls=["search_options:1:2"]
> > 
> 
> Well, thanks to the miracle of autobuild failures, I can put that in too.
> 
> Though actually the failure was not a miracle, just righteous vengence
> upon my patch which didn't handle RODCs very nicely (RODCs don't
> really participate in uptodateness calculations). One of the other
> tests leaves RODCs around. The short version is
> 
> make test TESTS='repl_rodc visualize_drs'
> 
> fails. Looking into this also revealed a source of flappiness, and I
> noticed something that would break in Python 3.
> 
> The new version removes the search options control and has the following changes
> squashed into patches 06 and 11.

Thanks, 

I've reviewed and pushed the updated patch set.  Lets see how this
goes.

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba