[Patch] lib/audit_logging Fix flapping test

Andrew Bartlett abartlet at samba.org
Sun Jun 10 04:40:33 UTC 2018

On Sun, 2018-06-10 at 06:08 +0200, Gary Lockyer via samba-technical
> Have seen failures of test_json_add_timestamp on sn_devel
> A summary of the autobuild process is here:
>   https://git.samba.org/abartlet/samba-autobuild/autobuild.log
> You can see logs of the failed task here:
>   https://git.samba.org/abartlet/samba-autobuild/samba-none-env.stdout
>   https://git.samba.org/abartlet/samba-autobuild/samba-none-env.stderr
> This patch widens the expected times to ensure that it passes reliably. The test is intended to ensure that a time stamp is generated and is correctly formatted and that the value is reasonable.
> In the failure the time stamp appears to be after the finish time, I'm guessing this is a precision/rounding issue but I'd appreciate any thoughts/insights.

I would love some thoughts from the broader team, but this looks like a
reasonable start while we all recover from SambaXP.

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

Pushed to autobuild.

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list