[PATCH] samba-tool visualize uptodateness

Andrew Bartlett abartlet at samba.org
Sun Jun 10 04:28:43 UTC 2018


On Sun, 2018-06-10 at 09:02 +1200, Douglas Bagnall wrote:
> Thanks Andrew. Pushed.
> 
> This is what I squashed in:
> 
> --- a/python/samba/netcmd/visualize.py
> +++ b/python/samba/netcmd/visualize.py
> @@ -687,11 +687,12 @@ class cmd_uptodateness(GraphCommand):
>      def get_utdv(self, samdb, dn):
>          """This finds the uptodateness vector in the database."""
>          cursors = []
> +        config_dn = samdb.get_config_basedn()
>          for c in dsdb._dsdb_load_udv_v2(samdb, dn):
>              inv_id = str(c.source_dsa_invocation_id)
> -            res = samdb.search(expression=("(&(invocationId=%s)"
> +            res = samdb.search(base=config_dn,
> +                               expression=("(&(invocationId=%s)"
>                                             "(objectClass=nTDSDSA))" % inv_id),
> -                               #scope=SCOPE_SUBTREE,
>                                 controls=["search_options:1:2"],
>                                 attrs=["distinguishedName", "invocationId"])

Thanks.  While it now won't do anything, I think you can now remove
the 

controls=["search_options:1:2"]

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list