[PATCH] Fix an assertion check

[Jeremy Allison]

On Mon, Jul 30, 2018 at 09:40:30AM +0200, Andreas Schneider wrote:
> On Saturday, 28 July 2018 00:18:26 CEST Jeremy Allison via samba-technical 
> wrote:
> > On Fri, Jul 27, 2018 at 12:17:05PM +0530, Anoop C S via samba-technical 
> wrote:
> > > Hi,
> > > 
> > > Attached patch fixes the assertion check while reducing the lock reference
> > > count. If it is the right thing to do we may also consider changing the
> > > assertion check while increasing the same lock reference count inside
> > > increment_lock_ref_count():
> > > 
> > > SMB_ASSERT(lock_ref_count < (INT32_MAX - 1))
> > > 
> > > Also the DEBUG statement[inside increment_lock_ref_count() and
> > > decrement_lock_ref_count()] prints the old reference count value instead
> > > of the new one.
> > > 
> > > Thanks,
> > > Anoop C S.
> > 
> > This patch is correct. Reviewed-by: Jeremy Allison <jra at samba.org>
> > 
> > Can I get a second Team reviewer ?
> 
> RB+, I guess we should open a bug for this and backport?

Hmmm. Maybe. This code has been in use for over 10 years
and hasn't caused an issue.

I'm OK with fixing on next release cycle.