clang-format a subsystem? (was: Re: [PATCH] LDB Rename and extract the key value code from the TDB specific code.)

Andrew Bartlett abartlet at
Mon Jul 30 09:30:50 UTC 2018

On Wed, 2018-07-25 at 09:53 +1200, Gary Lockyer via samba-technical
> As promised after the commit of the lmdb code, a series of patches
> renaming and separating the key value code in lib/ldb/ldb_tdb from the
> tdb specific code. Moving the generic key value code to
> lib/ldb/ldb_key_value, leaving the TDB specific code in lib/ldb/ldb_tdb.
> The patch set consists of a series of rename commits, each followed by a
> reformat commit.
> After the renames the key value code is moved to ldb_key_value and
> reformatted.

Thanks Gary.  I'm happy with everything except the final clang-format
pass.  I need to think about that some more, we haven't done that
before, so I suggest you do as you have suggested and run it over the
new audit code that has already been moved around and re-worked, and
then we come back to ldb.

I certainly appreciate the arguments for automatic code formatting,
because we have wasted so much time on code style issues. 

In the meantime, could you fix up the cases it highlighted where we
have a single-line if statement, and add some braces?  Those are
against our rules regardless.

Thank you so much for doing the rename, it is much more clear now.

For everything except the top patch:

Reviewed-by: Andrew Bartlett <abartlet at>

and pushed to autobuild.

Andrew Bartlett
Andrew Bartlett             
Authentication Developer, Samba Team
Samba Developer, Catalyst IT

More information about the samba-technical mailing list