[PATCH] ctdb-doc: Provide an example script for migrating old configuration (bug 13550)

[Martin Schwenke]

On Sun, 29 Jul 2018 01:20:44 +1000, Amitay Isaacs <amitay at gmail.com>
wrote:

> On Sat, Jul 28, 2018 at 5:11 PM, Martin Schwenke via samba-technical
> <samba-technical at lists.samba.org> wrote:
> > Include an example ctdbd.conf-style file for testing.
> >
> > CTDB in Samba 4.9 has a new style of configuration.  This can help
> > users migrate their configuration to the new style.  This is an example,
> > so is in doc/examples/.  Distros might decide to use a variation of it.  
> 
> The check for CTDB_NODES (and CTDB_PUBLIC_ADDRESSES) is not correct.
> The check for those should confirm that the variables are pointing to
> "standard" files in /etc/ctdb.  Right now the script compares the path
> to a directory where the files are put.  I would expect people to run
> this with "-d tmp_config" rather than "-d /etc/ctdb".

The problem is that the "standard" configuration is set at configure
time, so those who use /usr/local/etc/ctdb/ then wouldn't be able to use
this out of the box.

That's also why I made the script refused to overwrite without the -f
option.  It is quite safe to use in-place.

However, you're right.  It is still dodgy implied behaviour.  :-)

So, how about the attached fixup?  It still defaults to writing the
files in-place, but provides an option to put the output directory
somewhere else.  I think this is better.

peace & happiness,
martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fixup.patch
Type: text/x-patch
Size: 3141 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180729/c24d0d40/0001-fixup.bin>