[PATCH] Revert wrong third_party/popt patch

Martin Schwenke martin at meltin.net
Fri Jul 27 21:46:38 UTC 2018


On Sat, 28 Jul 2018 06:09:05 +1200, Andrew Bartlett via samba-technical
<samba-technical at lists.samba.org> wrote:

> On Fri, 2018-07-27 at 18:11 +0200, Volker Lendecke via samba-technical

> > Have no time to look at the alternatives, so revert the harmful patch.
> > 
> > Please review&push!
> > 
> > Thanks, Volker  
> 
> Did Amitay's patch not work?  It certainly did for me.
> 
> I posted a merge request with that and fixes to autobuild to keep it
> tested.
> 
> The pipeline is here, and looks pretty good:  
> 
> https://gitlab.com/catalyst-samba/samba/-/jobs/84972201
> 
> The merge request is here:
> 
> https://gitlab.com/samba-team/samba/merge_requests/34

I've hit the "approve" button.  Is that all you need to push with:

Reviewed-by: Martin Schwenke <martin at meltin.net>

?

peace & happiness,
martin



More information about the samba-technical mailing list