[PATCH] libads - Add net ads leave --keep-account option

[Justin Stephenson]

Hi,

This is fixed in the latest patch, see attached.

On Fri, Jul 27, 2018 at 3:06 AM, Amit via samba-technical <
samba-technical at lists.samba.org> wrote:

> Dear Justin,
>
> ASN: Thanks for review.
>
> It looks this code will show (null) in place of realm?
>
> # net ads leave --keep-account
> Disabled account for 'CAT06121354' in realm '(null)'
>
> It looks r->out.dns_domain_name does not have realm name..
>         if (r->out.disabled_machine_account) {
>                 d_printf(_("Disabled account for '%s' in realm '%s'\n"),
>                        r->in.machine_name, r->out.dns_domain_name);   <<<
>                 werr = WERR_OK;
>                 goto done;
>         }
>
> It would be great if you assure this.
>
> Thanks
> Amit
>
>
>
> On 07/27/2018 12:26 PM, Andrew Bartlett via samba-technical wrote:
> > On Fri, 2018-07-13 at 15:06 +1200, Andrew Bartlett via samba-technical
> > wrote:
> >> On Mon, 2018-07-09 at 09:16 -0400, Justin Stephenson wrote:
> >>> Thank you for the suggestions, I updated the ldbsearch to use the -H
> ldap:// URL connection and providing the credentials - updated patch
> attached.
> >>>
> >>> Kind regards,
> >>> Justin Stephenson
> >> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> >>
> >> I'm sorry we missed this for 4.9
> >>
> >> Can I get a second team reviewer please?
> > G'Day,
> >
> > Can I get a second team reviewer please?
> >
> > Thanks,
> >
> > Andrew Bartlett
> >
>
> --
> Thanks
> Amit Kumar
> !!If you stumble, get back up.
> What happened yesterday, no longer matters.
> Today is another day to move closer to your GOAL!!
>
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: net-ads-leave-keep-account.patch
Type: text/x-patch
Size: 5617 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180727/44b3347f/net-ads-leave-keep-account.bin>