Quota patches

David Disseldorp ddiss at samba.org
Fri Jul 27 12:20:46 UTC 2018


Hi Noel,

I didn't get a chance to review the full patchset, but one minor
comment...

On Thu, 26 Jul 2018 16:31:37 +0100, Noel Power via samba-technical wrote:

> diff --git a/librpc/idl/wscript_build b/librpc/idl/wscript_build
> index 75eba7d54a5..57e75363f72 100644
> --- a/librpc/idl/wscript_build
> +++ b/librpc/idl/wscript_build
> @@ -12,6 +12,7 @@ bld.SAMBA_PIDL_LIST('PIDL',
>                         drsblobs.idl efs.idl frstrans.idl mgmt.idl netlogon.idl
>                         notify.idl
>                         smb2_lease_struct.idl
> +                       quota.idl
>                         policyagent.idl scerpc.idl svcctl.idl wkssvc.idl eventlog6.idl backupkey.idl
>                         fsrvp.idl bkupblobs.idl fscc.idl frsblobs.idl witness.idl clusapi.idl
>                         mdssvc.idl winspool.idl''',

You're only making use of the ndr push/pull functionality here right? If
so, please move quota.idl down to the options='--header --ndr-parser'
section so that we're not generating more unused server/client/python
code.

Cheers, David



More information about the samba-technical mailing list