jra at samba.org
Thu Jul 26 20:56:03 UTC 2018
On Thu, Jul 26, 2018 at 04:31:37PM +0100, Noel Power via samba-technical wrote:
> Hi Jeremy,
> Please see attached v2 of the patch and also inline comments
> the statement "uint32_t max_data is always non-zero" is not true, in
> cliquota.c function 'cli_set_user_quota' calls 'build_user_quota_buffer'
> with max_data set to '0' So I added the tests above but they have been
> adjusted with that in mind
Looking at uses of build_user_quota_buffer(), both of
them set max_data to zero. So the correct thing to
do is simply remove it, as it's not limiting anything
(or maybe set it correctly to the limit for the trans
calls for smb1/smb2).
That makes things easier, as it then means we just have
to check for integer wrap.
There are a couple of other areas where we might want
to split out the code into functions.
Give me a little while and I'll send a modified version
of the patchset back for your review, hope that's OK.
More information about the samba-technical