[PATCH] always hide local symbols generated by binutils

Andrew Bartlett abartlet at samba.org
Fri Jul 13 02:10:51 UTC 2018


On Thu, 2018-07-12 at 15:18 +0300, Alexander Bokovoy via samba-
technical wrote:
> On to, 12 heinä 2018, Alexander Bokovoy via samba-technical wrote:
> > On to, 12 heinä 2018, Alexander Bokovoy via samba-technical wrote:
> > > On to, 12 heinä 2018, Alexander Bokovoy via samba-technical wrote:
> > > > Hi,
> > > > 
> > > > attached patch should make Samba libraries usable with upcoming binutils
> > > > 2.31. See https://bugzilla.redhat.com/show_bug.cgi?id=1600035 for
> > > > details of typical failures and explanation from binutils developers.
> > > > 
> > > > This is not a full solution as it does not get rid of multiple _end
> > > > symbols somehow generated by a linker. However, it should help with
> > > > linking against Samba libraries because those symbols will have a local
> > > > scope and would not fail the linkage.
> > > 
> > > Updated version that fixes expected results in buildtools/wafsamba/tests/test_abi.py 
> > 
> > Pipeline: https://gitlab.com/samba-team/devel/samba/pipelines/25615509
> 
> The pipeline is OK but I had a typo, _bss_start instead of __bss_start,
> thus a new version of the patch.

This seems reasonable.  

Thanks for keeping on top of this.

Pushed to autobuild.

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba




More information about the samba-technical mailing list