[PATCH] Add winbind request profiling

Jeremy Allison jra at samba.org
Thu Jul 12 23:53:59 UTC 2018


On Thu, Jul 12, 2018 at 04:36:12PM -0700, Jeremy Allison via samba-technical wrote:
> On Wed, Jul 11, 2018 at 11:04:37PM +0200, Ralph Böhme wrote:
> > On Wed, Jul 11, 2018 at 10:08:54PM +0200, Stefan Metzmacher wrote:
> > > Am 11.07.2018 um 16:45 schrieb Ralph Böhme via samba-technical:
> > > > On Tue, Jul 10, 2018 at 12:13:54AM +0200, Stefan Metzmacher via
> > > > samba-technical wrote:
> > > > > I guess I'll push it in the next days, most likely before 4.9.0rc1.
> > > > 
> > > > as discussed: the two winbindd patches reviewed-by-me.
> > > > 
> > > > *Really* nice stuff! :)
> > > 
> > > Ok, here's the patchset that passed a few private autobuilds.
> > > 
> > > Please recheck and push:-)
> > 
> > rechecked and pushed. Thanks for this amazing stuff that gave me some real hard
> > nuts to crack while reviewing. :)
> 
> Posthumous review notes #1. The 'busy' / 'destroyed' stuff
> is really clever, thanks ! Simplifies a lot of stuff...

Posthumous review notes #2. The tevent_context_wrapper() code
is *brillient*, but brainbending.

I can now see how impersonation gets done. Wow..

tevent_wrapper_push_use_internal()
wrapper_ops->before_XXX_handler()
ev->handler()
wrapper_ops->after_XXX_handler()
tevent_wrapper_pop_use_internal()

I'd like to say simple, but can't :-).

Quite though, thanks !

Jeremy.



More information about the samba-technical mailing list