[RFC PATCH v3 2/5] lib/audit_logging: make json_is_invalid() accept a const*

[Gary Lockyer]

That looks good and I'll include it in the api changes, could you send
it through as a attachment.

Gary.

On 12/07/18 19:04, Philipp Gesang via samba-technical wrote:
> Allow for json_is_invalid() to be used on a const pointer. The
> test does not require for the json object to be mutable so
> constraining it to non-const* is unnecessary.
> 
> Signed-off-by: Philipp Gesang <philipp.gesang at intra2net.com>
> ---
>  lib/audit_logging/audit_logging.c | 2 +-
>  lib/audit_logging/audit_logging.h | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/audit_logging/audit_logging.c b/lib/audit_logging/audit_logging.c
> index 293bd374866..d5fbad086d4 100644
> --- a/lib/audit_logging/audit_logging.c
> +++ b/lib/audit_logging/audit_logging.c
> @@ -354,7 +354,7 @@ void json_free(struct json_object *object)
>   * @return is the object valid?
>   *
>   */
> -bool json_is_invalid(struct json_object *object)
> +bool json_is_invalid(const struct json_object *object)
>  {
>  	return !object->valid;
>  }
> diff --git a/lib/audit_logging/audit_logging.h b/lib/audit_logging/audit_logging.h
> index b11597e6a1a..c8a3521f8ca 100644
> --- a/lib/audit_logging/audit_logging.h
> +++ b/lib/audit_logging/audit_logging.h
> @@ -55,7 +55,7 @@ struct json_object json_new_object(void);
>  struct json_object json_new_array(void);
>  void json_free(struct json_object *object);
>  void json_assert_is_array(struct json_object *array);
> -bool json_is_invalid(struct json_object *object);
> +bool json_is_invalid(const struct json_object *object);
>  
>  int json_add_int(struct json_object *object,
>  		 const char* name,
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180713/38eb245d/signature.sig>