[PATCH] Fix bug 13465

Ralph Böhme slow at samba.org
Thu Jul 12 08:10:36 UTC 2018

On Wed, Jul 11, 2018 at 02:52:14PM -0700, Christof Schmitt wrote:
>It also works on my cluster.

Thanks for testing! Which combinations did you test? As I've learnt in this
excersize, we should test all possible combinations, as most things are not
covered by autobuild:

Cluster (with include=registry):
- all commands as root
- all commands as user
- all commands without smb.conf
- all commands without install prefix dir run from build dir

The same on a non-clustered Samba. I guess we need a full matrix 4.7 vs
master+patchset as some combinations are likely broken in 4.7, like smbclient.

>One question: Why did you revert the smbclient patch? In the end it does not
>make a difference, as the popt credentials callback already initializes
>messaging, but it would be consistent with the other tools to keep it.

The idea was to only do the manual call where it's really needed. I'm currently
running CI where I've also reverted the last three patches for smbtree,
smbcquotas and smbcacls.


Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG Key Fingerprint:           FAE2 C608 8A24 2520 51C5
                               59E4 AA1E 9B71 2639 9E46

More information about the samba-technical mailing list