[PATCH] more PY2/PY3 compat changes

[Andrew Bartlett]

On Thu, 2018-07-05 at 07:04 +1200, Andrew Bartlett via samba-technical
wrote:
> On Wed, 2018-07-04 at 16:22 +0200, Andreas Schneider via samba-
> technical wrote:
> > On Wednesday, 27 June 2018 16:38:38 CEST Noel Power via samba-technical wrote:
> > > Hi,
> > > 
> > > More hopefully low hanging fruit patches, the exception I would see as
> > > '[PATCH 05/26] lib/ldb: Implement a bytes derived object for attributes
> > > py2/py3' which is the modification discussed on this list some time back
> > > (see https://lists.samba.org/archive/samba-technical/2018-May/127718.html)
> > > 
> > > This passed CI earlier, I squashed some patches and fixed some
> > > whitespace issues and resubmitted (should pass again)
> > > 
> > > please see attached for patch and
> > > https://gitlab.com/samba-team/devel/samba/pipelines/24688131 for CI
> > > 
> > > Branch is at
> > > https://gitlab.com/samba-team/devel/samba/commits/npower-python3-misc%232
> > 
> > I've reviewed them with some minor cosmetic changes. Attached is my patchset 
> > with my RB+.
> > 
> > Attaching it here if someone else wants to comment.
> 
> Thanks Andreas,
> 
> I would like Joe to take a look over this and comment.  
> 
> My understanding is that he found some issues around the str() handling
> but I distracted him onto customer work before he could report back. 
> 
> I'm just as keen to keep this moving, but please hold off for just a
> day or two while we get these ducks in a row.

We have a WIP merge request fixing the str() issue Joe and I identified
(samdb APIs that should really return integers, not direct LDB
strings/bytes) and there is a new merge request.

As this changes the python API for ldb we should take some care, and
not rush it into 4.9

https://gitlab.com/samba-team/samba/merge_requests/29

However it should land very soon.

Thank you for your patience.

Andrew Bartlett
-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba