tdb/talloc/ldb releases

[Stefan Metzmacher]

Am 11.07.2018 um 22:43 schrieb Andrew Bartlett via samba-technical:
> On Wed, 2018-07-11 at 22:30 +0200, Stefan Metzmacher via samba-
> technical wrote:
>> Hi,
>>
>> here're version bumps required before 4.9.0rc1.
>>
>> This should go in after the tevent related patches with tevent 0.9.37.
>>
>> Please review and push:-)
> 
> Before the ldb 1.4.1 we need to make it break Samba 4.8 (the getpid()
> changes in 1.4.0 break Samba 4.8).  I tried to re-use the existing
> infrastructure in ldb_module.h but couldn't make it work.
> 
> I'll try again today in between the other tasks but I'm clearly missing
> something or not testing it right.

Something like this should do it (use just need to replace '...' with
something useful.

diff --git a/lib/ldb/include/ldb_module.h b/lib/ldb/include/ldb_module.h
index fd88c6218ebd..082560bbd153 100644
--- a/lib/ldb/include/ldb_module.h
+++ b/lib/ldb/include/ldb_module.h
@@ -68,6 +68,21 @@
 #error "Samba < 4.7 is not compatible with this version of ldb due to
assumptions around read locks"
 #endif

+/*
+ * Only Samba versions which expect ldb >= 1.4.0
+ * are compatible with ... behaviour.
+ *
+ * See https://bugzilla.samba.org/show_bug.cgi?id=....
+ */
+#if EXPECTED_SYSTEM_LDB_VERSION_MAJOR > 1
+#define __LDB_..._COMPATIBLE__ 1
+#elif EXPECTED_SYSTEM_LDB_VERSION_MINOR > 3
+#define __LDB_..._COMPATIBLE__ 1
+#endif
+#ifndef __LDB_..._COMPATIBLE__
+#error "Samba < 4.9 is not compatible with this version of ldb due to
assumptions around ..."
+#endif
+
 #endif /* defined(_SAMBA_BUILD_) && defined(USING_SYSTEM_LDB) */

 struct ldb_context;



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180712/559f9326/signature.sig>