[PATCH] s3/rpc_server: Character Encode Spotlight Queries

[Jeremy Allison]

On Mon, Jul 09, 2018 at 10:06:40PM +0200, Ralph Böhme wrote:
> On Mon, Jul 09, 2018 at 11:27:49AM -0700, Jeremy Allison wrote:
> > On Sat, Jul 07, 2018 at 11:03:14AM +0200, Ralph Böhme via samba-technical wrote:
> > > Hi!
> > > 
> > > Attached find a patch for the Spotlight RPC server. Please review&push if
> > > happy. Thanks!
> > 
> > Looks OK from a C point of view, just a quick question
> > on semantics before I RB+ though.
> > 
> > "scope" comes from the user query (i.e. client specified)
> > yeah ?
> > 
> > What implication does G_URI_RESERVED_CHARS_ALLOWED_IN_PATH
> > have on g_uri_escape_string() ?
> 
> <https://developer.gnome.org/glib/stable/glib-URI-Functions.html>
> <https://developer.gnome.org/glib/stable/glib-URI-Functions.html#G-URI-RESERVED-CHARS-ALLOWED-IN-PATH:CAPS>
> 
> Iirc it allows "/" unescaped in URIs. Where it is called in the Spotlight RPC
> service we want to convert user passed strings of the form "/foo bar/buz" to
> "/foo%20bar/buz" in order to pass them to Tracker via libtracker-sparql.
> 
> Does that explain the situation? I don't see any security implications but I'm
> half blind on that eye.

Ah, OK - that makes sense. Nope, don't see any security implications
myself know I understand what it's doing :-).

RB+ and pushed !

Jeremy.