#ifdef required for more syslog facility names (was: Re: Minor problem with commit 32e5b18d493)

Timur I. Bakeyev timur at freebsd.org
Mon Jul 9 23:06:52 UTC 2018

On 8 July 2018 at 21:26, Timur I. Bakeyev <timur at com.bat.ru> wrote:

> On 8 July 2018 at 20:00, Andrew Bartlett <abartlet at samba.org> wrote:
>> On Fri, 2018-07-06 at 18:33 -0500, Christopher O Cowan via samba-
>> technical wrote:
>> > LOG_FTP is not defined in /usr/include/sys/syslog.h on some platforms
>> like
>> > AIX, so these 3 files need an #ifdef LOG_FTP wrapper, like LOG_NTP.
>> > I quickly compared and noticed there's no LOG_AUTHPRIV on AIX either,
>> even
>> > though I find it on RHEL.
>> Can you prepare a merge request for this, ideally after a little
>> research to work out what the 'original' set of names in early unix was
>> or a general solution to handle any of them being missing is?
> Seems there are more vendor specific facilities, including LOG_LAUNCHD for
> MacOSX.
> Well, nothing #ifndef can't handle :) I'll add the facilities list from
> Perl's Sys::Syslog, taking into account it's
> broad platform coverage, should be good enough.

I've pushed https://gitlab.com/samba-team/samba/merge_requests/25 that
should address all those issues.

There is also a https://gitlab.com/samba-team/samba/merge_requests/19 that
should update WHATSNEW.TXT
with the information about the made changes.

With regards,
Timur Bakeyev.

More information about the samba-technical mailing list