[PATCH] Fix bug 13465

Christof Schmitt cs at samba.org
Mon Jul 9 22:36:09 UTC 2018


On Mon, Jul 09, 2018 at 11:06:54PM +0200, Ralph Böhme via samba-technical wrote:
> On Mon, Jul 09, 2018 at 11:05:35PM +0200, Ralph Böhme via samba-technical wrote:
> >On Mon, Jul 09, 2018 at 04:56:44PM +0200, Ralph Böhme wrote:
> >>On Sat, Jul 07, 2018 at 02:58:21PM +0200, Ralph Böhme wrote:
> >>>On Sat, Jul 07, 2018 at 02:48:11PM +0200, Ralph Böhme via samba-technical wrote:
> >>>>On Sat, Jul 07, 2018 at 01:50:48PM +0200, Ralph Böhme via samba-technical wrote:
> >>>>>Looking...
> >>>>
> >>>>this ones works better. messaging initialisation requires
> >>>>root priveleges or out wrappers, neither is given in these
> >>>>python test.
> >>>>
> >>>>The new version uses the same approach as smbpasswd. It
> >>>>passed a local make test this time, full CI is currently
> >>>>running at:
> >>>>
> >>>>https://gitlab.com/samba-team/devel/samba/pipelines/25313916
> >>>
> >>>and here's the patch.
> >>
> >>sorry, but this one now doesn't work correctly in the clustered case. We really
> >>need a clustered test env in autobuild.
> >>
> >>I'll post a (hopefully) correct patch later on. Amazing how such a simple thing
> >>can be such a pita. :)
> >
> >I'm puzzled. If anyone has any idea why this fails in samba.tests.docs with
> >
> >  fstype
> >    Expected: NTFS
> >    Got:    ntvfs handler
> >    Expected: unixuid, default
> >    Got:    printjob username
> >    Expected: %U
> >    Got:
> >
> >Branch: https://gitlab.com/samba-team/devel/samba/commits/slow-autobuild
> 
> fwiw, local reproducer:
> 
> $ PYTHONPATH=bin/python python source4/scripting/bin/subunitrun samba.tests.docs

This test calls testparm internally. The problem there is that 

bin/testparm -s paramtestsmb.conf -v | less

shows an empty default for fstype with your patches applied. Removing
the call to client_messaging_context from testparm avoids this problem
and testparm again reports the NTFS default for fstype. I will keep
digging for the underlying cause.

Christof



More information about the samba-technical mailing list