[PATCH] Initialize value of written in cli_splice_fallback

Jeremy Allison jra at samba.org
Mon Jul 9 17:19:37 UTC 2018


On Mon, Jul 09, 2018 at 06:37:50PM +0200, David Disseldorp via samba-technical wrote:
> On Fri, 6 Jul 2018 12:13:31 -0700, Jeremy Allison via samba-technical wrote:
> 
> > > Once you've OK'ed it can I get a second Team
> > > reviewer ?  
> > 
> > David, Bailey has already sent in the DSO
> > so this patch is ready for second Team review.
> 
> Both patches look good to me, though the cli_splice_fallback()
> reinitialisation isn't really needed now that you've added it at the top
> level. I take it you'd like to have both as belt and braces?

Yep, in case it gets re-used in other code. Good to have
it done right in both places.



More information about the samba-technical mailing list