[RFC PATCH v2 1/3] lib/audit_logging: make json_is_valid() accept a const*
Philipp Gesang
philipp.gesang at intra2net.com
Mon Jul 9 09:12:48 UTC 2018
-<| Quoting Philipp Gesang <philipp.gesang at intra2net.com>, on Monday, 2018-07-09 11:08:21 AM |>-
> Allow for json_is_valid() to be used on a const pointer. The test
^^^^^^^^^^^^^^^
json_is_invalid(), of course.
> does not require for the json object to be mutable so
> constraining it to non-const* is unnecessary.
>
> Signed-off-by: Philipp Gesang <philipp.gesang at intra2net.com>
> ---
> lib/audit_logging/audit_logging.c | 2 +-
> lib/audit_logging/audit_logging.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/audit_logging/audit_logging.c b/lib/audit_logging/audit_logging.c
> index 6ca3fe9b8fd..0aff67e8852 100644
> --- a/lib/audit_logging/audit_logging.c
> +++ b/lib/audit_logging/audit_logging.c
> @@ -361,7 +361,7 @@ void json_free(struct json_object *object)
> * @return is the object valid?
> *
> */
> -bool json_is_invalid(struct json_object *object)
> +bool json_is_invalid(const struct json_object *object)
> {
> return !object->valid;
> }
> diff --git a/lib/audit_logging/audit_logging.h b/lib/audit_logging/audit_logging.h
> index b11597e6a1a..c8a3521f8ca 100644
> --- a/lib/audit_logging/audit_logging.h
> +++ b/lib/audit_logging/audit_logging.h
> @@ -55,7 +55,7 @@ struct json_object json_new_object(void);
> struct json_object json_new_array(void);
> void json_free(struct json_object *object);
> void json_assert_is_array(struct json_object *array);
> -bool json_is_invalid(struct json_object *object);
> +bool json_is_invalid(const struct json_object *object);
>
> int json_add_int(struct json_object *object,
> const char* name,
> --
> 2.13.6
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180709/cb4b5dcd/signature.sig>
More information about the samba-technical
mailing list