% subs removed from force user and force group (was: Re: [PATCH] fix a few talloc_tos leaks)

[David Disseldorp]

Hi Andrew,

On Sun, 08 Jul 2018 08:07:38 +1200, Andrew Bartlett wrote:

> If you intended to remove % subs from 'force user' and 'force group'
> you need to document that in the WHATSNEW, as give the shocking variety
> of configuration files in use, I'm pretty sure that one is in use
> somewhere.   'force user = %S' would be a good one for some use cases
> (but thankfully the easiest to work around).
> 
> Now, the land-mine you tripped over is the meaning of 'const' in the
> XML doc strings.  It means that that smb.conf parameter is used
> directly, and not % substituted.  A patch to change the XML keyword to
> percent_sub_disallowed would be very valuable.

Yes, I was aware of the lp const string behaviour, but didn't know that
we supported force user / group with substitutions. To avoid any
disruption, my preference would be to revert this patch-set in its
entirety. Patch to follow...

Cheers, David