% subs removed from force user and force group (was: Re: [PATCH] fix a few talloc_tos leaks)

[Andrew Bartlett]

On Mon, 2018-06-25 at 13:28 +0200, David Disseldorp via samba-technical 
wrote:
> Review / push appreciated.
> 
> Cheers, David

G'Day David,

If you intended to remove % subs from 'force user' and 'force group'
you need to document that in the WHATSNEW, as give the shocking variety
of configuration files in use, I'm pretty sure that one is in use
somewhere.   'force user = %S' would be a good one for some use cases
(but thankfully the easiest to work around).

Now, the land-mine you tripped over is the meaning of 'const' in the
XML doc strings.  It means that that smb.conf parameter is used
directly, and not % substituted.  A patch to change the XML keyword to
percent_sub_disallowed would be very valuable.

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba