[PATCH] s3/rpc_server: Character Encode Spotlight Queries
abartlet at samba.org
Sat Jul 7 19:59:57 UTC 2018
On Sat, 2018-07-07 at 13:12 +0200, Ralph Böhme wrote:
> On Sat, Jul 07, 2018 at 09:34:13PM +1200, Andrew Bartlett wrote:
> > The patch looks good, but shouldn't there be some kind of test for
> > spotlight that this should extend? I can't find any but perhaps I'm
> > not looking hard enough.
> yup, because sadly there aren't *any* test.
> We currently only implement the RPC server, not the client. That was outside of
> the scope of my initial work on this and then unfurtantely this never really
> took of. Sorry!
> This is a hidden gem that doesn't get the attention it deserves, which is really
> sad given what a nice feature this is.
We can't undo the past, but for others in the the future it should be
said: we don't normally accept features on this basis.
- Samuel's great DFS-R patches are blocked because he only has a
client, so can't test it (alternate testing strategies will be a
- We removed the 'net rpc vampire' code because we don't have a server
(and it broke)
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical