[PATCH] Fix bug 13465

Ralph Böhme slow at samba.org
Sat Jul 7 11:50:48 UTC 2018


pOn Thu, Jul 05, 2018 at 05:00:53PM +0200, Ralph Böhme wrote:
>Attached is a fix for bug 13465. Please review&push if happy. Thanks!

this fails in autobuild in samba.tests.docs:

UNEXPECTED(failure): samba.tests.docs.samba.tests.docs.SmbDotConfTests.test_default_s3(none)
REASON: Exception: Exception: Traceback (most recent call last):
  File "/memdisk/jra/a/b4044880/samba-none-env/bin/python/samba/tests/docs.py", line 156, in test_default_s3
    self._test_default(['bin/testparm'])
  File "/memdisk/jra/a/b4044880/samba-none-env/bin/python/samba/tests/docs.py", line 208, in _test_default
    "Parameters that do not have matching defaults:"))
AssertionError: Parameters that do not have matching defaults:

    binddns dir
      Expected: /m/jra/a/b4044880/prefix/samba-none-env/bind-dns
      Got: /MEMDISK/JRA/A/B4044880/SAMBA-NONE-ENV/BIN/AB/CLIENT/BIND-DNS
    cache directory
      Expected: /m/jra/a/b4044880/prefix/samba-none-env/var/cache
      Got: /MEMDISK/JRA/A/B4044880/SAMBA-NONE-ENV/BIN/AB/CLIENT/CACHEDIR
    fstype
      Expected: NTFS
      Got:

    ....

Sorry, I didn't expect this fix for testparm to be able to have such an
effect. The patch just ensures messaging is initialized.

Looking...

Fwiw, I re-pushed the other patches from your failed autobuild.

-slow

-- 
Ralph Boehme, Samba Team       https://samba.org/
Samba Developer, SerNet GmbH   https://sernet.de/en/samba/
GPG Key Fingerprint:           FAE2 C608 8A24 2520 51C5
                               59E4 AA1E 9B71 2639 9E46



More information about the samba-technical mailing list