[WIP] [PATCH] vfs_streams_xattr: Don't terminate streams with extra '\0' byte.
slow at samba.org
Thu Jul 5 08:58:53 UTC 2018
On Fri, Jun 29, 2018 at 11:09:38PM +0200, Timur I. Bakeyev via samba-technical wrote:
>This is a work in progress, while being already successfully running on
>FreeBSD for half a year(with few bugs fixed in the meantime) that I
>originally done to break 64K limit for the stream size, stored in the
>extended attribute. This limit is hardcoded in the `get_ea_value()` which
>is used by current implementation to store streams in the xattr.
yes, we should definitely fix that.
>Incidentally that also fixes the issue where xattrs are forced to be
>nul-terminated, which create interoperability issues:
Unfortunately, as also said in the bugreport, it's too late to change the
What we could do would be add it as an option, defaulting to the old
behaviour. I don't think we will ever be able to switch the default, requiring
uses to convert all xattr with some tool. That just won't work.
Can you please provide minimal patches that only changes one thing at a time?
Also, when updating DEBUG macros please use the new systle macros like DBG_DEBUG
for level 10.
Ralph Boehme, Samba Team https://samba.org/
Samba Developer, SerNet GmbH https://sernet.de/en/samba/
GPG Key Fingerprint: FAE2 C608 8A24 2520 51C5
59E4 AA1E 9B71 2639 9E46
More information about the samba-technical