[PATCH] domain rename tool

Gary Lockyer gary at catalyst.net.nz
Wed Jul 4 18:58:22 UTC 2018


RB+ and pushed to autobuild
Gary

On 04/07/18 20:56, Andrew Bartlett via samba-technical wrote:
> On Wed, 2018-07-04 at 17:20 +1200, Tim Beale via samba-technical wrote:
>> Hi,
>>
>> Updated changes attached. I've split the changes into two patch-sets, in
>> the hope it's a bit easier to digest that way.
>>
>> patch-set1: This just lays more groundwork for the rename tool. These
>> changes are identical to what I sent out yesterday.
>> CI link: https://gitlab.com/catalyst-samba/samba/pipelines/25070802
>>
>> patch-set2: This adds the rename tool. Since yesterday's patch, I've
>> changed:
>> - #1 - minor change to add 'show_deleted:1' to the dbcheck controls in
>> fix_old_dn_attributes()
>> - #4 - added a new test_one_way_links() test-case that adds some basic
>> objects/links and checks they get renamed correctly.
>> - #5 - new patch to run dbcheck over the restored DB (I noticed that
>> removing the old DCs introduces a couple of dbcheck errors)
>> CI link: https://gitlab.com/catalyst-samba/samba/pipelines/25082629
>>
>> Review appreciated.
> 
> This looks really good, and a pretty amazing result!
> 
> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> 
> Can I get a second team reviewer please?
> 
> Thanks,
> 
> Andrew Bartlett
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20180705/ea98fc0f/signature.sig>


More information about the samba-technical mailing list