[PATCH] Make "none" the default setting for vfs_full_audit

Andrew Bartlett abartlet at samba.org
Wed Jul 4 09:32:49 UTC 2018

On Mon, 2018-07-02 at 04:34 +0200, Timur I. Bakeyev via samba-technical 
> This patch is a suggestion to change the default behavior of the
> vfs_full_audit.
> Currently, by just adding the module to the list of VFS objects you enable
> auditing of ALL operations. We've observed with our end users that this
> almost instantly brings even moderately loaded server to it's knees.
> So, proposed patch turns off auditing of both successful and failed
> operations by default. It's still possible to audit ALL the operations by
> specifying "all" keyword, but practice shows that it's a bad idea unless
> you are doing it in the controlled test environment.

This seems reasonable, and matches what is used in make test.

Can you humour me with a gitlab CI run please?

Assuming that passes and you can include a patch to WHATSNEW.txt
explaining the change:

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list