How to get review

Andrew Bartlett abartlet at
Wed Jul 4 08:34:16 UTC 2018

On Wed, 2018-07-04 at 03:36 +0200, Timur I. Bakeyev wrote:
> On 3 July 2018 at 21:07, Andrew Bartlett <abartlet at> wrote:
> > On Tue, 2018-07-03 at 15:51 +0200, Timur I. Bakeyev via samba-technical 
> > wrote:
> > > Hi!
> > > 
> > > Can I get a review, please?
> > > 
> > > With regards,
> > > Timur.
> > 
> > Can you push it to GitLab so I can see a CI result?
> > 
> > (I know it seems petty, but it saves me so much time in silly build
> > issues that I now ask it of essentially everyone.)
> Sure I will, whatever would help you to concentrate on actual issues.
> In general, I wonder, what is the best and shortest way nowadays to reach developers
> and get a review? Over time I went through bugzilla, samba-tech ML, IRC, GitHub PR :)

I'm trying to make that single spot be a GitLab Merge Request against  I hope others agree, as it will
give us a single list of outstanding stuff where existing reviews can
be collected. 

The secret to success there will actually come from if this becomes
where patches are discussed in general, because then
might become a daily check-in spot for team members when they do their
morning code review and coffee routine. 

Back in the present, the current best practice is to push a branch,
then write a mail here with:
 - the patch as a patch.txt file
 - the CI link
 - the gitlab link

And beg for review (hence why I'm looking forward with hope to us just
using merge requests, to save the duplication). 

> I know you do tremendous amount of reviews, but seems there is no other way to ensure 
> the quality of submissions...
> And still two of my recent mails didn't get any reaction.

I know.  It doesn't help that being at the pointy end of the release
cycle, there is much going on everywhere. 

Andrew Bartlett

Andrew Bartlett             
Authentication Developer, Samba Team
Samba Developer, Catalyst IT

More information about the samba-technical mailing list